Add rails release details to the rails releases table#89
Merged
etagwerker merged 4 commits intomainfrom Oct 1, 2024
Merged
Conversation
This will make it easier to set up GitHub Actions based on the right version numbers
gdiaz-ol
approved these changes
Sep 30, 2024
gdiaz-ol
left a comment
gdiaz-ol
left a comment
There was a problem hiding this comment.
LGTM, just a small question/suggestion.
lib/tasks/data.rake
Outdated
| end | ||
|
|
||
| desc "Update minimum Ruby versions from Rails 2.3 to 7.2" | ||
| task update_rails_releases: :environment do |
There was a problem hiding this comment.
would make sense to add find_or_create_rails_releases as prerequisites task after environment ?
Member
Author
|
@gdiaz-ol I just updated the PR with your feedback. Please take another look. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This will make it easier to set up GitHub Actions based on the right version numbers. I'm trying to get this in the
mainbranch so that later I can use it in #84Most of the information came from these resources:
Please check it out.
Thanks!